-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Survey metadata #87
Survey metadata #87
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple small questions, but I think we'll be able to get this over the finish line today.
fobi_custom/plugins/form_handlers/collect_data/fobi_form_handlers.py
Outdated
Show resolved
Hide resolved
fobi_custom/plugins/form_handlers/collect_data/fobi_form_handlers.py
Outdated
Show resolved
Hide resolved
@@ -1,5 +1,5 @@ | |||
[tool:pytest] | |||
DJANGO_SETTINGS_MODULE = tests.test_config | |||
DJANGO_SETTINGS_MODULE = justspaces.settings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change just because the test settings weren't changing anything? Do the tests not use a separate DB?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, they were the same and it seemed like an unnecessary hassle to have to change settings in two places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small question here -- either the dedent I pointed out is a typo which you can fix quickly, or there's a semantic reason for it and it can stay. Either way, feel free to merge once you've made that call!
|
||
def plugin_data_repr(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would expect this to be a method on the class too, but it looks like it's dedented. Is there a reason for that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a holdover from Fobi! I don't see a need to mess with it, since it works and I'm not sure where else it's used in the package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds great, thanks for clarifying.
Overview
Connects #63. Creates elements for survey metadata. Related issues that came out of this but should be addressed separately: #88; #91; #92; #93
To Do
Add fields on survey model:
Add form elements:
Other things:
Total
form element. And maybetime_start
,time_stop
,method
, andrepresentation
. Open a new issue to handle these. (update: issue Pick a method for handling PLDP required fields #88)Testing Instructions
pg_restore -C -j4 --no-owner just-spaces.dump | psql
python manage.py migrate
Connects #63