Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Survey metadata #87

Merged
merged 15 commits into from
Apr 22, 2019
Merged

Survey metadata #87

merged 15 commits into from
Apr 22, 2019

Conversation

beamalsky
Copy link
Contributor

@beamalsky beamalsky commented Apr 16, 2019

Overview

Connects #63. Creates elements for survey metadata. Related issues that came out of this but should be addressed separately: #88; #91; #92; #93

To Do

Add fields on survey model:

  • location
  • study

Add form elements:

  • total
  • time_start
  • time_stop
  • time_character
  • representation
  • microclimate
  • temperature_c
  • method

Other things:

Testing Instructions

  • If you don't already have it, create the database: pg_restore -C -j4 --no-owner just-spaces.dump | psql
  • Migrate: python manage.py migrate
  • Login as testuser (password in the DataMade LastPass under "Just Spaces Staging")
  • Create a new survey
  • Add some of the metadata fields
  • Publish your survey
  • Submit it. Do the fields save as you'd expect on the survey model?

Connects #63

@beamalsky beamalsky requested a review from jeancochrane April 17, 2019 19:41
@jeancochrane jeancochrane changed the title [WIP] Survey metadata Survey metadata Apr 17, 2019
Copy link
Contributor

@jeancochrane jeancochrane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small questions, but I think we'll be able to get this over the finish line today.

@@ -1,5 +1,5 @@
[tool:pytest]
DJANGO_SETTINGS_MODULE = tests.test_config
DJANGO_SETTINGS_MODULE = justspaces.settings
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change just because the test settings weren't changing anything? Do the tests not use a separate DB?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, they were the same and it seemed like an unnecessary hassle to have to change settings in two places.

@beamalsky beamalsky requested a review from jeancochrane April 22, 2019 18:44
Copy link
Contributor

@jeancochrane jeancochrane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small question here -- either the dedent I pointed out is a typo which you can fix quickly, or there's a semantic reason for it and it can stay. Either way, feel free to merge once you've made that call!


def plugin_data_repr(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect this to be a method on the class too, but it looks like it's dedented. Is there a reason for that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a holdover from Fobi! I don't see a need to mess with it, since it works and I'm not sure where else it's used in the package.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds great, thanks for clarifying.

@beamalsky beamalsky merged commit 3ca57bc into master Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants