-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pulsar dependency to 2.10.3 #144
Conversation
1fd2e90
to
a0fcd0b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switching to 2.10.x requires more work.
The default settings changed a lot, by default now there is a limit on the memory used by the producer and not on the number of pending messages.
I suggest to apply a default configuration similar to 2.8.3
Please take a look to the changes we did in CNDB in order to achieve better results.
The gist of it is to disable the memory limit and configure the max pending messages
PTAL. |
Behavior of the JsonNode node returned in the NativeObject has changes. I have to tests failing now with:
With 2.8.3, I would get "1.0" when accessing Need to troubleshoot further... Update: Regression was introduced in 2.10.1. I captured the issue here apache/pulsar#20092 In the mean time, I downgraded the client in the tests to 2.8.3 (like it was before). This Patch is still meaning full because it successfully update the client on the agent side to 2.10.3 and the connector client is only used in the integration tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
2.8 has performance reported issue, recommended to update to 2.10.x. Please note that the connector pulsar client will be vended by the environment, but this upgrade benefits the agent. It also unified the client version between the Agent and CLI tool.
Notes: