[Improvement] Correct type specification of create_fileset function in fileset_catalog.py #3508
Assignees
Labels
improvement
Improvements on everything
Comments
jerryshao
pushed a commit
that referenced
this issue
May 23, 2024
…ate_fileset function (#3509) ### What changes were proposed in this pull request? * Change the suggest type of `type` from `Catalog.Type` to `Fileset.Type` ### Why are the changes needed? Fix: #3508 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? `./gradlew :clients:client-python:test` Co-authored-by: TimWang <[email protected]>
github-actions bot
pushed a commit
that referenced
this issue
May 23, 2024
…ate_fileset function (#3509) ### What changes were proposed in this pull request? * Change the suggest type of `type` from `Catalog.Type` to `Fileset.Type` ### Why are the changes needed? Fix: #3508 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? `./gradlew :clients:client-python:test` Co-authored-by: TimWang <[email protected]>
yuqi1129
pushed a commit
that referenced
this issue
May 23, 2024
…ate_fileset function (#3535) <!-- 1. Title: [#<issue>] <type>(<scope>): <subject> Examples: - "[#123] feat(operator): support xxx" - "[#233] fix: check null before access result in xxx" - "[MINOR] refactor: fix typo in variable name" - "[MINOR] docs: fix typo in README" - "[#255] test: fix flaky test NameOfTheTest" Reference: https://www.conventionalcommits.org/en/v1.0.0/ 2. If the PR is unfinished, please mark this PR as draft. --> ### What changes were proposed in this pull request? * Change the suggest type of `type` from `Catalog.Type` to `Fileset.Type` ### Why are the changes needed? Fix: #3508 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? `./gradlew :clients:client-python:test` Co-authored-by: noidname01 <[email protected]> Co-authored-by: TimWang <[email protected]>
diqiu50
pushed a commit
to diqiu50/gravitino
that referenced
this issue
Jun 13, 2024
…of create_fileset function (apache#3509) ### What changes were proposed in this pull request? * Change the suggest type of `type` from `Catalog.Type` to `Fileset.Type` ### Why are the changes needed? Fix: apache#3508 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? `./gradlew :clients:client-python:test` Co-authored-by: TimWang <[email protected]>
coolderli
pushed a commit
that referenced
this issue
Dec 17, 2024
…ate_fileset function (#3509) ### What changes were proposed in this pull request? * Change the suggest type of `type` from `Catalog.Type` to `Fileset.Type` ### Why are the changes needed? Fix: #3508 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? `./gradlew :clients:client-python:test` Co-authored-by: TimWang <[email protected]> (cherry picked from commit ee6b9db)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What would you like to be improved?
The suggest type of argument
typeincreate_fileset()isCatalog.Type, which should beFileset.TypeHow should we improve?
No response
The text was updated successfully, but these errors were encountered: