Add support for pinning multiple domains with a single OkHttpClient #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveShenouda
force-pushed
the
support-multiple-domains
branch
from
4be4802 to
9479fb9
Compare
nabla-c0d3
suggested changes
Feb 27, 2020
README.md
Outdated
| @@ -116,20 +116,25 @@ protected void onCreate(Bundle savedInstanceState) { | |||
| connection.setSSLSocketFactory(TrustKit.getInstance().getSSLSocketFactory(serverHostname)); | |||
|
|
|||
| // OkHttp 2.x | |||
| RootTrustManager trustManager = new RootTrustManager(); | |||
There was a problem hiding this comment.
OkHttpHelper
- getSSLSocketFactory()
- getPinningInterceptor()
| String host = mServerHostname.get(); | ||
| DomainPinningPolicy serverConfig = | ||
| TrustKit.getInstance().getConfiguration().getPolicyForHostname(host); | ||
| if (serverConfig == null) { |
There was a problem hiding this comment.
What's the need for the if/else here? What about TrustKit.getInstance().getTrustManager(host).checkServerTrusted(chain, authType) in all cases?
There was a problem hiding this comment.
Added a comment to address the need
SteveShenouda
force-pushed
the
support-multiple-domains
branch
from
ad814a4 to
0955f28
Compare
added 3 commits
February 27, 2020 19:46
Add support for SSL pinning validation on multiple different domains with a single OkHttp3 client
Add support for SSL pinning validation on multiple different domains with a single OkHttp2 client
SteveShenouda
force-pushed
the
support-multiple-domains
branch
from
0955f28 to
9593b87
Compare
SteveShenouda
force-pushed
the
support-multiple-domains
branch
from
9593b87 to
7273b2d
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.