Simple debugger completion #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That is awesome work, well done! Could you go ahead and fix the Clippy issues, as well? Additionally, if you like feel free to send another PR with an update to the README linking to |
Thanks 🙂 Fixed the clippy issues in the newest commit. Seems like all of them was from other parts of the code than the ones addressed in this PR. |
|
Oh whoops, well...thanks for cleaning up regardless. Hopefully I'll have some time in the next few days to do a release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My attempt at #166.
Implements simple debugger completion with symbols, built-in stuff (cpu registers, cpu.flags, ram etc.). It's a little hard-coded, but that's because I didn't find a common place to unify the different things. I saw that the locals-view and other variable-views were a bit hardcoded as well (especially the flags). Hopefully this is okay 🙂 Unit tests, and have also done manual testing in Emacs, using mos-mode (my own creation to use mos in an easy way from Emacs). Everything works as expected (even completing when you have finished most of it, e.g, cpu.fla completes correctly to cpu.flags). Unsure if anything should be added, as the current completion solves all my needs.