Allow setting of registers when debugging #257
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements setVariable requests for the debugger, and support setting registers values (includes support for VICE using register set operation). Supports sending in decimals, hexadecimals and binary values (e.g,
128
,$d0
and%00001000
respectively). It should be easy enough to extend the support to other types of variables as well, but have kept that as future work to not make the PRs too large. There is also a minor challenge with name crashes (e.g,X
as both a variable and a register name) that should be thought of before implementing regular variables. (simplest solution is simply to not allow those name crashes). One TODO addresses a future improvement that might help the implementation of general variable setting.Fixes #110
Unsure if/where this should be documented. Feel free to suggest something 🙂