Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switched FormSelect to use ResolveNow to mitigate race condition #676

Merged
merged 1 commit into from
Mar 30, 2022
Merged

Switched FormSelect to use ResolveNow to mitigate race condition #676

merged 1 commit into from
Mar 30, 2022

Conversation

puehringer
Copy link
Contributor

Closes #675

dvvanessastoiber
dvvanessastoiber approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@dvvanessastoiber dvvanessastoiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in my tests, thank you for the implementation! 👍

@dvvanessastoiber dvvanessastoiber merged commit b89b346 into develop Mar 30, 2022
@dvvanessastoiber dvvanessastoiber mentioned this pull request Mar 30, 2022
Merged
2 tasks
@puehringer puehringer deleted the mp/675_form_select_use_resolvenow branch February 3, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvvanessastoiber dvvanessastoiber dvvanessastoiber approved these changes

Assignees

@dvvanessastoiber dvvanessastoiber

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@puehringer @dvvanessastoiber