Skip to content
This repository has been archived by the owner on Jan 13, 2023. It is now read-only.

Avoid Directory Traversal #23

Merged
merged 3 commits into from
Jul 28, 2021
Merged

Conversation

d-hayashi
Copy link
Contributor

What?

Add a function to check the given file-path to avoid Directory Traversal

Why?

To improve security

@hdl-service hdl-service added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 26, 2021
@d-hayashi d-hayashi changed the title Avoid Directory Traversal [WIP] Avoid Directory Traversal Jul 26, 2021
@hdl-service hdl-service added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 26, 2021
@d-hayashi d-hayashi changed the title [WIP] Avoid Directory Traversal Avoid Directory Traversal Jul 26, 2021
@hdl-service hdl-service removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 26, 2021
@d-hayashi
Copy link
Contributor Author

/cc @yusukefs

@hdl-service hdl-service requested a review from yusukefs July 26, 2021 06:05
@d-hayashi d-hayashi removed the request for review from WatanabeToshimitsu July 26, 2021 06:05
Copy link
Contributor

@yusukefs yusukefs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

すみません遅くなりました!
LGTM

@hdl-service hdl-service added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2021
@hdl-service
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: d-hayashi, yusukefs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hdl-service hdl-service merged commit 325324e into master Jul 28, 2021
@hdl-service hdl-service deleted the feature/avoid-directory-traversal branch July 28, 2021 04:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants