Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: cannot specify podsecuritypolicies #97

Closed
weitzjdevk opened this issue Jul 1, 2020 · 2 comments
Closed

Bug: cannot specify podsecuritypolicies #97

weitzjdevk opened this issue Jul 1, 2020 · 2 comments

Comments

@weitzjdevk
Copy link
Contributor

It is not possible to override the podsecuritypolicies, as they are defined as an "array", but referenced as a map
weitzj pushed a commit to devk-insurance/ambassador-chart that referenced this issue Jul 1, 2020
@weitzjdevk
Fix datawire#97: Cannot specify podSecurityPolicies
5d7bb14 
If one want to use a custom `values.yaml` for their Helm chart,
the bundled `values.yaml` of the existing Helm chart will get
merged with the custom values.yaml.

Since the bundled `values.yaml` defines an array `[]` for
podsecuritypolicies, but the podsecuritypolicies.yaml template
expects a map for `annotation:` and `spec:`, it is not possible
to generate a valid Helm chart.

The only workaround would be to ignore/delete the bundled values.yaml
altogether.

This PR fixes this issue by using a map: `{}` as a default value for
the bundled `values.yaml`

Fixes:
- datawire#97
@weitzjdevk weitzjdevk mentioned this issue Jul 1, 2020
Merged
@weitzjdevk
Copy link
Contributor Author

@nbkrause

@inercia inercia closed this as completed in 822caa6 Jul 6, 2020
inercia added a commit that referenced this issue Jul 6, 2020
@inercia
Merge pull request #98 from devk-insurance/fix/97-podsecuritypolicies…
9532be1 
…-type

Fix #97: Cannot specify podSecurityPolicies
@weitzjdevk
Copy link
Contributor Author

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@weitzjdevk