Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set additional deployment labels #114

Merged
merged 3 commits into from
Jul 24, 2020
Merged

Set additional deployment labels #114

merged 3 commits into from
Jul 24, 2020

Conversation

jasons42
Copy link
Contributor

No description provided.

iNoahNothing
iNoahNothing approved these changes Jul 24, 2020
View reviewed changes
Copy link
Contributor

@iNoahNothing iNoahNothing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iNoahNothing
Copy link
Contributor

Could you update the Changelog and put this under the "Next Release" section?

@jasons42
Copy link
Contributor Author

Could you update the Changelog and put this under the "Next Release" section?

Updated.

inercia
inercia suggested changes Jul 24, 2020
View reviewed changes
Copy link
Contributor

@inercia inercia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to improve the CI tests, could you add some deploymentLabels in one of the ci/*-values.yaml, so the correctness of the rendered Deployment could be tested?

@jasons42
Copy link
Contributor Author

In order to improve the CI tests, could you add some deploymentLabels in one of the ci/*-values.yaml, so the correctness of the rendered Deployment could be tested?

@inercia I added an additional values file so as not to mix the concerns of the existing tests. Please let me know if that doesn't work for you.

inercia
inercia approved these changes Jul 24, 2020
View reviewed changes
Copy link
Contributor

@inercia inercia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks @jasons42

@inercia inercia merged commit 6f9dd9a into datawire:master Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inercia inercia inercia approved these changes

@iNoahNothing iNoahNothing iNoahNothing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasons42 @iNoahNothing @inercia