write_cassandra block #124
#215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zalmane
reviewed
Dec 18, 2022
zalmane
reviewed
Dec 18, 2022
zalmane
reviewed
Dec 18, 2022
zalmane
reviewed
Dec 18, 2022
zalmane
reviewed
Dec 18, 2022
| async def run(self, data: List[Dict[str, Any]]) -> Tuple[List[Dict[str, Any]], List[Result]]: | ||
| logger.debug(f"Running {self.get_block_name()}") | ||
|
|
||
| data = write_utils.write_records(data, self.opcode_field, self.execute_upsert, self.execute_delete) |
There was a problem hiding this comment.
I assume we need to open a 'transaction' here? is there such a concept in cassandra?
There was a problem hiding this comment.
not the same thing, see:
https://docs.datastax.com/en/cassandra-oss/2.2/cassandra/dml/dmlTransactionsDiffer.html
zalmane
reviewed
Dec 18, 2022
zalmane
reviewed
Dec 19, 2022
| return utils.produce_data_and_results(data) | ||
|
|
||
| def get_future(self, stmt: PreparedStatement, record: Dict[str, Any]) -> Any: |
There was a problem hiding this comment.
do we need a method for 2 lines if this is only called in one place? may be more maintainable to just inline
There was a problem hiding this comment.
It's called from two places.
zalmane
reviewed
Dec 19, 2022
…, insert and update
zalmane
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.