Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Check if a translation macro actually exists #803

Open
mal-tee opened this issue Oct 24, 2021 · 3 comments
Open

test: Check if a translation macro actually exists #803

mal-tee opened this issue Oct 24, 2021 · 3 comments
Labels
i18n Internationalization testing

Comments

@mal-tee
Copy link
Member

mal-tee commented Oct 24, 2021

We should also write a test that checks if a macro is defined, if it's used in the translations. Feel free to move this into a new issue.

Originally posted by @mal-tee in #802 (comment)

@baltpeter
Copy link
Member

Can you elaborate on what you mean by that?

@mal-tee
Copy link
Member Author

mal-tee commented Oct 24, 2021

If a translation string uses ${x}, x should be defined in the macro section. :D

@baltpeter
Copy link
Member

But that's the other way compared to what the issue says. :P

Either way, how would you implement that? I don't see a way to do that through Cypress (other than what I already did in #802). Do you want to establish another testing framework?

@zner0L zner0L changed the title We should also write a test that checks if a macro is defined, if it's used in the translations. Feel free to move this into a new issue. test: Check if a translation macro actually exists Oct 27, 2021
@zner0L zner0L added i18n Internationalization testing labels Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Internationalization testing
Development

No branches or pull requests

3 participants