-
-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce macros in the translation files #802
Conversation
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also write a test that checks if a macro is defined, if it's used in the translations. Feel free to move this into a new issue. |
Why? I don't see a need for that. Isn't this equivalent to using a variable instead (which we are already doing in lots of places)? |
7d5424a
to
3e04476
Compare
Just as a heads-up that things changed. I thought they might want to use that feature as well, e.g. for language-specific things. But we don't have to do that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Huh, I want to remove dependency on this script, not introduce more… I have to fix all of this in #701 |
I know, but we need some processing on the translations files anyway. And this is a huge win for maintaining the different language versions. |
No description provided.