Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for wrong spellings of the association's name #804

Open
mal-tee opened this issue Oct 24, 2021 · 3 comments
Open

Test for wrong spellings of the association's name #804

mal-tee opened this issue Oct 24, 2021 · 3 comments
Labels
good first issue Good for newcomers testing

Comments

@mal-tee
Copy link
Member

mal-tee commented Oct 24, 2021

I think we should move the name of our association into a macro (#802), to enforce the spelling, i.e. don't have different versions (space, no space, nbsp, ...) of the "e.V." part. :D

@baltpeter
Copy link
Member

baltpeter commented Oct 24, 2021

I agree with the intent, however two problems that I see:

  • There's only two places in the translation files that use the name. The rest (and vast majority) is in content pages which wouldn't be covered by the macro.
  • Semantically, this really doesn't fit as a translation. I worry people might view that as an invitation to translate the association's name (however that might work).

@mal-tee
Copy link
Member Author

mal-tee commented Oct 24, 2021

Good points. Then maybe a (regex-based) test?

@baltpeter
Copy link
Member

I guess you could do that.

@mal-tee mal-tee added good first issue Good for newcomers testing labels Aug 7, 2023
@mal-tee mal-tee changed the title Move association's name into macro Test for wrong spellings of the association's name Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers testing
Development

No branches or pull requests

2 participants