refactor: stats compute string length stats for string type only
#2471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before, we were also computing for ints/floats, which didn't make sense thinking more about it. At first, I was thinking it can be used to compute storage of numbers as strings, but other than that special case, it wasnt that useful
and not other data types as well. This should also make stats a little bit faster
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before, we were also doing so for int/float types, thinking it will be useful for storage capacity planning as numbers are often stored as strings.
But strictly speaking, computing length for numbers doesn't really make sense (we can derive that with other stats anyway).
This change make
statsrun a bit faster too...