Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor filtering implementation #7

Merged
merged 8 commits into from
Apr 27, 2023
Merged

Refactor filtering implementation #7

merged 8 commits into from
Apr 27, 2023

Conversation

tdabasinskas
Copy link
Member

@tdabasinskas tdabasinskas commented Apr 26, 2023

Refactor filtering implementation to resolve #6.

We couldn't continue using map, as it does not allow filtering on multiple values of the same field (i.e., use OR) as per documentation.

@tdabasinskas tdabasinskas self-assigned this Apr 26, 2023
Took 8 minutes
Took 1 minute
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #7 (aaa199b) into main (10fc17b) will decrease coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
- Coverage   96.80%   96.62%   -0.18%     
==========================================
  Files          11       11              
  Lines         282      267      -15     
==========================================
- Hits          273      258      -15     
  Misses          6        6              
  Partials        3        3              
Impacted Files Coverage Δ
backstage/entity.go 95.58% <100.00%> (-0.80%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tdabasinskas tdabasinskas merged commit 7f11858 into main Apr 27, 2023
@tdabasinskas tdabasinskas deleted the filters branch April 27, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question about Filtering
1 participant