a test to cover a previously uncaught exception in RecentInvestJobs. n…

…atcap#1119
davemfish · Dec 5, 2022 · dcee66e · dcee66e
1 parent 5171d42
commit dcee66e
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 1 deletion.
diff --git a/workbench/src/renderer/app.jsx b/workbench/src/renderer/app.jsx
@@ -197,7 +197,6 @@ export default class App extends React.Component {
   }
 
   render() {
-    throw new Error('help')
     const {
       investList,
       investSettings,

diff --git a/workbench/src/renderer/components/HomeTab/index.jsx b/workbench/src/renderer/components/HomeTab/index.jsx
@@ -124,6 +124,7 @@ class RecentInvestJobs extends React.Component {
     const recentButtons = [];
     const { recentJobs } = this.props;
     recentJobs.forEach((job) => {
+      if (!job.argsValues) { return; }
       recentButtons.push(
         <Card
           className="text-left recent-job-card"

diff --git a/workbench/tests/renderer/app.test.js b/workbench/tests/renderer/app.test.js
@@ -341,6 +341,30 @@ describe('Display recently executed InVEST jobs on Home tab', () => {
     });
   });
 
+  test('Recent Jobs: a job with incomplete data is skipped', async () => {
+    const job1 = new InvestJob({
+      modelRunName: 'carbon',
+      modelHumanName: 'invest A',
+      argsValues: {
+        workspace_dir: 'dir',
+      },
+      status: 'success',
+    });
+    const job2 = new InvestJob({
+      // argsValues is missing
+      modelRunName: 'sdr',
+      modelHumanName: 'invest B',
+      status: 'success',
+    });
+    await InvestJob.saveJob(job1);
+    await InvestJob.saveJob(job2);
+
+    const { findByText, queryByText } = render(<App />);
+
+    expect(await findByText(job1.modelHumanName)).toBeInTheDocument();
+    expect(queryByText(job2.modelHumanName)).toBeNull();
+  });
+
   test('Recent Jobs: placeholder if there are no recent jobs', async () => {
     const { findByText } = render(
       <App />