forked from ankidroid/Anki-Android
-
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
build(deps): update to anki 25.01 RC & fix breakages
https://github.com/ankitects/anki/releases/tag/25.01rc1 https://github.com/ankitects/anki/releases/tag/25.01beta1 Fixes 17845 - Anki 25.01 Fixes 17681 - Fixed in: https://redirect.github.com/ankitects/anki/commit/4ee6dacaa32f4be7623381541b70142bb936c2cb feat: [Anki 25.01] handle new deckOptions backend methods Two are introduced by Anki 25.01 * **deckOptionsReady** * Called when deck options WebView is ready to receive requests. * This is piped through, but not implemented * **deckOptionsRequireClose** * Force closing the deck options Introduced in https://redirect.github.com/ankitects/anki/commit/d7fc98d4d87a0e07a228ab36c4ce2b1d7187690c https://redirect.github.com/ankitects/anki/pull/3571 These methods are part of upstream moving away from bridge commands, replacing them with HTTP calls (which we handle with `PostRequestHandler`) The workflow is now: * anki.deckOptionsPendingChanges() is called on back press * If no changes, deckOptionsRequireClose() is called * Otherwise, confirm() is called * on OK, deckOptionsRequireClose() is called * no-op on cancel Implementation: * Handle methods in PostRequestHandler * via calling through to DeckOptions * document new workflow * remove unused methods * remove bridgeCommands Fixes 14438 - 'back' button shows discard dialog Issue 15788 - Uses a better 'Discard' message
- Loading branch information
1 parent
4a52cef
commit bb37b65
Showing
3 changed files
with
37 additions
and
27 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters