Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows #4

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Windows #4

wants to merge 3 commits into from

Conversation

suburbanworrier
Copy link

Small fixes required to reduce friction on Windows

  • Makefile tweak required to fix inevitable problematic "Program Files" path on Windows specifically but should continue to work on other platforms (and handle spaces in folder/directory names)
  • package.json included to allow npm install of assumed tiddlywiki dependency
  • Minor documentation updates to suit

This PR addresses both #3 and #2 by providing the fixes @davidag suggests.

@suburbanworrier
Copy link
Author

Works for me on Windows but haven't yet tested that this doesn't break elsewhere.

Thanks for the project @davidag, it's been useful for collating my various TW experiments over the decades.

@davidag
Copy link
Owner

davidag commented Apr 12, 2024

Thx @suburbanworrier!! I'll review this and test it on Linux to validate it still works. I'll keep this PR updated with my findings 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants