Using commit search to identify new contributors #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current approach to checking for new contributors does not work in repositories with more than 500 contributors because the contributors list API endpoint only associates the first 500 committer emails with GitHub usernames. See rust-lang#41 for more explanation. This commit modifies the new contributor check to use the commit search API endpoint. A drawback of this approach is that (at least currently) that endpoint does not provide useful information for fork repositories, which is why the new contributor check has a condition on whether the repository is a fork.
davidalber
force-pushed
the
test-new-contrib-with-commit-search
branch
from
82727fb to
9636e3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current approach to checking for new contributors does not work in repositories with more than 500 contributors because the contributors list API endpoint only associates the first 500 committer emails with GitHub usernames. See rust-lang#41 for more explanation.
This commit modifies the new contributor check to use the commit search API endpoint. A drawback of this approach is that (at least currently) that endpoint does not provide useful information for fork repositories, which is why the new contributor check has a condition on whether the repository is a fork.