Add Tab as an alternative shortcut for accepting inline completion (j…

…upyterlab#16565) * Update Completer shortcuts * updates docs * removes unintended changes * fix * changes editor extensions completer invoke back to "Tab" * update docs * add Alt+End back as an option for inline-completer:accept * fix inline completer adding keys seperately * revert documentation test file * update hover image
davidbrochart · Aug 28, 2024 · 0b12f66 · 0b12f66
1 parent d2c54cf
commit 0b12f66
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/galata/test/documentation/commands.test.ts-snapshots/commandsList-documentation-linux.json b/galata/test/documentation/commands.test.ts-snapshots/commandsList-documentation-linux.json
@@ -1309,7 +1309,7 @@
     "label": "Accept Inline Completion",
     "caption": "",
     "shortcuts": [
-      "Alt End"
+      "Tab"
     ]
   },
   {

diff --git a/...-completer.test.ts-snapshots/inline-completer-shortcuts-on-jupyterlab-linux.png b/...-completer.test.ts-snapshots/inline-completer-shortcuts-on-jupyterlab-linux.png
diff --git a/packages/completer-extension/schema/inline-completer.json b/packages/completer-extension/schema/inline-completer.json
@@ -17,6 +17,11 @@
       "selector": ".jp-mod-completer-enabled",
       "preventDefault": false
     },
+    {
+      "command": "inline-completer:accept",
+      "keys": ["Tab"],
+      "selector": ".jp-mod-inline-completer-active"
+    },
     {
       "command": "inline-completer:accept",
       "keys": ["Alt End"],