Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add php-scrypt as a example project #146

Merged

Conversation

PineappleIOnic
Copy link
Contributor

@PineappleIOnic PineappleIOnic commented Jul 25, 2022

Hey There 👋

We at Appwrite recently created an extension using this library to fix an issue we had with the standard C-based php-scrypt by rewriting it in rust. Thanks to this library being so easy to use, we could get a working version in less than a day!

We would love it if you could add it as an example project in this repository to give more examples of how to use this library.

Thank you for reviewing this pull request,
Bradley Schofield

Copy link
Collaborator

@ptondereau ptondereau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your example!
I see that you don't have any PHP stub in your library.
You can use this mini tutorial https://github.com/ptondereau/ext-redlock-php#generating-php-stubs (because the cargo stubs command is unstable for the moment)

@PineappleIOnic
Copy link
Contributor Author

PineappleIOnic commented Jul 27, 2022

@ptondereau Thank you for reviewing our example, I was wondering where we should place our stubs within the repo once we have generated them? Is there a standard for this? or should we add it to our build steps?

@ptondereau
Copy link
Collaborator

@ptondereau Thank you for reviewing our example, I was wondering where we should place our stubs within the repo once we have generated them? Is there a standard for this? or should we add it to our build steps?

IMHO, it's up to you: I would go to exposing the stubs with a dedicated Packagist entry. In the ext's repository, add all stubs to a composer.json with a name in a manner that your user just need to composer install vendor/ext-stubs

@davidcole1340 davidcole1340 merged commit 1da812c into davidcole1340:master Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants