Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to show PHP warnings (etc) #231

Merged
merged 3 commits into from
Jul 18, 2023
Merged

Add ability to show PHP warnings (etc) #231

merged 3 commits into from
Jul 18, 2023

Conversation

joehoyle
Copy link
Collaborator

I don't believe there's a way for extensions to trigger PHP notices or warnings currently. This is done using the php_error_docref function. I've placed a function in ext_php_rs::php_error() however, there might be a better place?

@ptondereau ptondereau force-pushed the add-php-error branch 2 times, most recently from a2c9e83 to dd30c37 Compare March 13, 2023 17:03
I don't believe there's a way for extensions to trigger PHP notices or warnings currently. This is done using the `php_error_docref` function. I've placed a function in `ext_php_rs::php_error()` however, there might be a better place?
Copy link
Collaborator

@ptondereau ptondereau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ptondereau ptondereau merged commit a9dffe0 into master Jul 18, 2023
@ptondereau ptondereau deleted the add-php-error branch July 18, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants