Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to use zend apis for array iteration #240

Merged
merged 1 commit into from
May 16, 2023
Merged

Switch to use zend apis for array iteration #240

merged 1 commit into from
May 16, 2023

Conversation

joehoyle
Copy link
Collaborator

Fixes #218

@ptondereau
Copy link
Collaborator

Hey @joehoyle thanks for the PR!
By any chance, did you try your code against the example in the associated issue?

@joehoyle
Copy link
Collaborator Author

@ptondereau I tested this against our test suite in an internal project that makes quite heavy of use arrays, however I didn't have a test case for the reversal method yet.

I think it would be best to add tests to array.rs at the end perhaps? I don't really have a good example in the project to follow though. It looks like for the most part the only tests we are are via rust-skeptic, and it's not clear to me if those tests run php with an extension loaded, or are purely testing Rust functions without the PHP FFI being present.

@ptondereau
Copy link
Collaborator

@joehoyle I agree that we need non regression tests here. I'll dig into rust-skeptic later. For now, I think I'll merge it

@ptondereau ptondereau merged commit 1f9946f into master May 16, 2023
@ptondereau ptondereau deleted the zend-iter branch May 16, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segment Fault passing a vector as argument
2 participants