Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add streams API, ProcessGlobals, FileGlobals and SapiGlobals #249

Merged
merged 42 commits into from
Nov 24, 2023

Conversation

joehoyle
Copy link
Collaborator

@joehoyle joehoyle commented Jul 7, 2023

This is akin to ExecutorGlobals, but for the process globals

joehoyle added 4 commits July 7, 2023 13:45
This is akin to ExecutorGlobals, but for the process globals
@joehoyle
Copy link
Collaborator Author

@ptondereau do you know what config / version to build the bingings from? I think that's why this is failing!

@joehoyle joehoyle changed the title Add ProcessGlobals Add ProcessGlobals and SapiGlobals Jul 13, 2023
@ptondereau
Copy link
Collaborator

Hey @joehoyle if you want to update the doc binding, you need to use the latest stable version of PHP with debug mode.
When 8.3 will be out, you should update it and use this one

@joehoyle joehoyle requested a review from ptondereau July 19, 2023 11:50
@joehoyle joehoyle changed the title Add ProcessGlobals and SapiGlobals Add ProcessGlobals, FileGlobals and SapiGlobals Jul 19, 2023
@danog
Copy link
Collaborator

danog commented Oct 10, 2023

Mind rebasing pls?

@joehoyle
Copy link
Collaborator Author

@danog ah thanks, was also just fixing conflicts but looks like you got it! I was struggling to regenerate docsrs_bindings. I'm using homebrew [email protected]` but it seems that's not actually a ZEND_DEBUG build of php

@danog
Copy link
Collaborator

danog commented Nov 24, 2023

I was struggling to regenerate docsrs_bindings

Yeah I just compiled php-src from source with --enable-debug and ran cargo clean; cargo build; cp target/debug/build/ext-php-rs-*/out/bindings.rs docsrs_bindings.rs, pretty simple

@joehoyle
Copy link
Collaborator Author

Ah ok cool, yup got that now. However it looks like maybe the ones in the repo are generated from Linux? I'm seeing some additions for Darwin when I'm running it under macos

@danog danog changed the title Add ProcessGlobals, FileGlobals and SapiGlobals Add streams API, ProcessGlobals, FileGlobals and SapiGlobals Nov 24, 2023
@danog danog merged commit 5de7c7f into master Nov 24, 2023
26 checks passed
@danog danog deleted the process-globals branch November 24, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants