[Feature] custom SAPI #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelwurtz
commented
Oct 30, 2023
| pub fn send_header_function(mut self, func: SapiSendHeaderFunc) -> Self { | ||
| self.module.send_header = Some(func); | ||
| self | ||
| } |
There was a problem hiding this comment.
a lot of thing can be defined but ATM this is the only required function for PHP to not segfault (that's why we set a dummy handler if nothing is set latter)
There was a problem hiding this comment.
That's enough for me, let's make it evolve when users will have more usage
joelwurtz
commented
Oct 30, 2023
joelwurtz
commented
Oct 30, 2023
| } | ||
|
|
||
| unsafe { | ||
| php_module_startup(sapi, module); |
There was a problem hiding this comment.
here we create our own sapi with our own module so we can add function to php, this avoid the previous hack (zend_register_module) which does not work for a lot of cases (like registering classes)
joelwurtz
commented
Oct 30, 2023
| php_module_startup(sapi, module); | ||
| } | ||
|
|
||
| let result = unsafe { php_request_startup() }; |
There was a problem hiding this comment.
Since we separate module startup / request startup we can imagine having a loop here to handle multiple requests / execution with memory cleaned between them
ptondereau
reviewed
Oct 30, 2023
ptondereau
reviewed
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR is to provide a safe API around creating it's own SAPI for PHP
Actually there is only basic stuff and no wrapper at all and a test to show / confirm how it works.
I'm not sure about which API to provide to make things easier if someone want to create it's own SAPI.
Macro are out of scope for this PR (as i prefer to wait for the new macros to be merged and i think we can do a first version without them)