Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 8.3, SAPI globals support #284

Merged
merged 4 commits into from
Nov 21, 2023
Merged

Conversation

danog
Copy link
Collaborator

@danog danog commented Nov 21, 2023

No description provided.

@danog danog merged commit 2067c31 into davidcole1340:master Nov 21, 2023
12 of 26 checks passed
@joehoyle
Copy link
Collaborator

Nice one, but why are we merging failing builds?

@danog
Copy link
Collaborator Author

danog commented Nov 24, 2023

Only Windows builds were failing, due to some delay on PHP's part in the release of the 8.3 Windows SDK; mac and linux builds were all passing, so a quick re-run of workflow once the SDK gets released will fix everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants