Add support for field and method properties #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vodik
approved these changes
Sep 19, 2021
example/skel/src/lib.rs
Outdated
Comment on lines
5
to
6
| #[prop(flags = PropertyFlags::Private, rename = "Hello")] | ||
| a: i32, |
There was a problem hiding this comment.
Would it make sense to pick up syn::Visibility here? Would it ever make sense to have different levels of visibility between rust and php?
There was a problem hiding this comment.
This should have been removed but we can't change the property visibility at the moment, I'm pretty sure it's done through the property reflection which doesn't work with field properties.
davidcole1340
force-pushed
the
struct_properties
branch
from
dd82701 to
f9ddeeb
Compare
Technically, the zend object _could_ move in memory, leaving dangling references in the properties hashtable. We will just build the hashtable when required.
davidcole1340
force-pushed
the
struct_properties
branch
from
f9ddeeb to
8d6f5f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.