Add class constructors #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidcole1340
force-pushed
the
constructor
branch
from
c8125a1 to
ee24bf1
Compare
davidcole1340
commented
Oct 2, 2021
src/php/types/object.rs
Outdated
| impl<'a, T: RegisteredClass> FromZval<'a> for &'a mut T { | ||
| const TYPE: DataType = DataType::Object(Some(T::CLASS_NAME)); | ||
| // TODO(david): mutable FromZval? | ||
| // impl<'a, T: RegisteredClass> FromZval<'a> for &'a mut T { |
There was a problem hiding this comment.
Because Zval::object() was changed to return an immutable reference, FromZval can no longer be implemented for &mut T. I think we will need to add a new trait FromZvalMut, and then any type which implements FromZval can implement FromZvalMut.
There was a problem hiding this comment.
Perhaps this should be done in a later PR as it will require keeping a mutable Zval inside Arg
vodik
approved these changes
Oct 2, 2021
davidcole1340
force-pushed
the
constructor
branch
from
e08b0f9 to
a153cce
Compare
davidcole1340
force-pushed
the
constructor
branch
from
a153cce to
ba9488d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constructor methods can now be specified. They are required if
you want to construct the class from PHP. This replaces the
Defaultimplementation requirement on class objects.
Constructors can return
SelforResult<Self, E>whereE: Into<PhpException>.