Add ZBox<T>
to replace owned variants
#94
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently types which cannot be owned directly are owned through wrapper types, such as
ZendString -> ZendStr
,OwnedHashTable -> HashTable
,ClassObject -> ZendObject
, since they are allocated using the Zend memory manager and cannot be stored in a box.This PR introduces a new type
ZBox<T>
and a new traitZBoxable
. A type allocated using the Zend memory manager will implementZBoxable
, and can then be stored inside aZBox<T>
.There are no 'safe' constructor methods on
ZBox
. These are to be implemented on the boxed types. For example,ZendStr
has a functionfrom_c_str
which returns aZBox<ZendStr>
.