Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort out duplicate setup.py instances #209

Closed
daviddrysdale opened this issue Sep 2, 2021 · 1 comment · Fixed by #210
Closed

Sort out duplicate setup.py instances #209

daviddrysdale opened this issue Sep 2, 2021 · 1 comment · Fixed by #210

Comments

@daviddrysdale
Copy link
Owner

#7 added a top-level setup.py file to help pip cope with the code being in a subdirectory.

Need to check whether this is still needed. If it is still required, then some mechanism to keep the two files in sync is needed.

@AA-Turner
Copy link
Contributor

Per https://pip.pypa.io/en/stable/topics/vcs-support/#url-fragments, sub-dir installs now seem to be viable

A

daviddrysdale added a commit that referenced this issue Sep 2, 2021
Commit 3258a5b ("Add experimental top-level copy of setup.py")
added a top-level copy of setup.py to help pip cope with the code
being in a subdirectory.

Pip now copes with subdirectories [1], so remove this.

Fixes #209.

[1]: https://pip.pypa.io/en/stable/topics/vcs-support/#url-fragments
 # Please enter the commit message for your changes. Lines starting
daviddrysdale added a commit that referenced this issue Sep 2, 2021
Commit 3258a5b ("Add experimental top-level copy of setup.py")
added a top-level copy of setup.py to help pip cope with the code
being in a subdirectory.

Pip now copes with subdirectories [1], so remove this.

Fixes #209.

[1]: https://pip.pypa.io/en/stable/topics/vcs-support/#url-fragments
daviddrysdale added a commit that referenced this issue Sep 2, 2021
Commit 3258a5b ("Add experimental top-level copy of setup.py")
added a top-level copy of setup.py to help pip cope with the code
being in a subdirectory.

Pip now copes with subdirectories [1], so remove this.

Fixes #209.

[1]: https://pip.pypa.io/en/stable/topics/vcs-support/#url-fragments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants