-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add reminder about values setting in defaults guide #775
docs: add reminder about values setting in defaults guide #775
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @davidlj95 and the rest of your teammates on Graphite |
📦 Bundle size (Angular v17)Git ref:
Base size data is not available yet. Try again when the CI/CD has finished running on main branch |
📦 Bundle size (Angular v15)Git ref:
Base size data is not available yet. Try again when the CI/CD has finished running on main branch |
📦 Bundle size (Angular v16)Git ref:
Base size data is not available yet. Try again when the CI/CD has finished running on main branch |
📦 Bundle size (Angular v18)Git ref:
Base size data is not available yet. Try again when the CI/CD has finished running on main branch |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #775 +/- ##
=======================================
Coverage 97.42% 97.42%
=======================================
Files 75 75
Lines 350 350
Branches 61 61
=======================================
Hits 341 341
Partials 9 9 ☔ View full report in Codecov by Sentry. |
🎉 This PR is included in version 1.0.0-beta.12 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Issue or need
When adding the library to one of my projects, found out that defaults were not being applied. Turns out neither routing module had been provided or
NgxMetaService.set
was called, so nothing happened.Fixes #776
Proposed changes
Remember in defaults guide that a metadata values setting process must happen in order for defaults to be applied
Quick reminders