Pass strings through wildcard key redaction #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per davidmarkclements#31, we currently throw a `TypeError` when we try to apply a wildcard key redaction configuration to a string target. Strings spoofed themselves into an object code path due to gotchas like: ```js Object.keys('string') // => [ '0', '1', '2', '3', '4', '5' ] ``` We already bail early on nullish targets, so we can extend this behaviour to cover string targets as well. Other primitives are already handled safely but I've added tests to cover them off.
|
Unrelated to this change, it looks like CI is failing on Node.js 6 due to a new tap > [email protected] patch version using an object literal spread. If we want to keep Node.js 6 compatibility we can try locking that dependency to v2.0.0. |
|
cc @mcollina, if you have a moment to review 🙇 |
|
@davidmarkclements Is there anything else that needs to be done so that this can get merged and released? Do you need help with anything? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #31, we currently throw a
TypeErrorwhen we try to apply a wildcard key redaction configuration to a string target. Strings spoofed themselves into an object code path due to gotchas like:We already bail early on nullish targets, so we can extend this behaviour to cover string targets as well. Other primitives are already handled safely but I've added tests to cover them off.