Update validator to remove Node vm dependency #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsumners
reviewed
Feb 9, 2023
There was a problem hiding this comment.
I don't think these implementations are equivalent. The current implementation runs the code in a completely new V8 context (https://nodejs.org/api/vm.html#what-does-it-mean-to-contextify-an-object). The proposed change runs the code in the same context with access to the parent scope.
I'm interested to hear @davidmarkclements's and @mcollina's views on this.
|
Why would you do this? |
|
I would like to use fast-redact in a Deno project, but Deno currently does not support vm. While the code running has access to the parent scope it should have no side effects, and vm should not be used as a security mechanism per the node documentation. Related Article |
|
I don't think vm is actually needed here. |
renovate bot
referenced
this pull request
in valora-inc/logging
May 18, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [fast-redact](https://togithub.com/davidmarkclements/fast-redact) | [`^3.1.2` -> `^3.2.0`](https://renovatebot.com/diffs/npm/fast-redact/3.1.2/3.2.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>davidmarkclements/fast-redact</summary> ### [`v3.2.0`](https://togithub.com/davidmarkclements/fast-redact/releases/tag/v3.2.0) [Compare Source](https://togithub.com/davidmarkclements/fast-redact/compare/v3.1.2...v3.2.0) ##### What's Changed - docs(paths): add a specific call-out for hyphens by [@​dncrews](https://togithub.com/dncrews) in [https://github.com/davidmarkclements/fast-redact/pull/56](https://togithub.com/davidmarkclements/fast-redact/pull/56) - fix: updated redaction mechanism for wild cards above level 2 by [@​gurjotkaur20](https://togithub.com/gurjotkaur20) in [https://github.com/davidmarkclements/fast-redact/pull/58](https://togithub.com/davidmarkclements/fast-redact/pull/58) - Update validator to remove Node vm dependency by [@​mikehw](https://togithub.com/mikehw) in [https://github.com/davidmarkclements/fast-redact/pull/53](https://togithub.com/davidmarkclements/fast-redact/pull/53) ##### New Contributors - [@​dncrews](https://togithub.com/dncrews) made their first contribution in [https://github.com/davidmarkclements/fast-redact/pull/56](https://togithub.com/davidmarkclements/fast-redact/pull/56) - [@​gurjotkaur20](https://togithub.com/gurjotkaur20) made their first contribution in [https://github.com/davidmarkclements/fast-redact/pull/58](https://togithub.com/davidmarkclements/fast-redact/pull/58) - [@​mikehw](https://togithub.com/mikehw) made their first contribution in [https://github.com/davidmarkclements/fast-redact/pull/53](https://togithub.com/davidmarkclements/fast-redact/pull/53) **Full Changelog**: davidmarkclements/fast-redact@v3.1.2...v3.2.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - "after 8:00 before 23:00 every weekday except on Friday" in timezone UTC. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/valora-inc/logging). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS45My4wIiwidXBkYXRlZEluVmVyIjoiMzUuOTMuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing
vmreferences and replacing the validation code with a Function eval.This change should enable the use of fast-redact in browsers and Deno.
Addresses issue #37