Allow down casting query trail interface and union types #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidpdrsn
force-pushed
the
allow-converting-between-query-trail-types
branch
2 times, most recently
from
dda0318 to
920c0c0
Compare
davidpdrsn
force-pushed
the
allow-converting-between-query-trail-types
branch
from
920c0c0 to
ceaa301
Compare
This is part of fixing davidpdrsn/juniper-eager-loading#15. In order to perform eager loading on a `Vec<User>` you need to know which associations are being queried. The `QueryTrail<User, _>` type has that information. However, this doesn't work for interfaces since if you have an interface called for example `Entity` you will not get a `QueryTrail<User, _>` but instead a `QueryTrail<Entity, _>`. That doesn't work to eager load users, which means you cannot eager at all. This is because `Entity` is an enum with a variant for each type that implements that interface. With this change we also generate implementations of `Into` for `QueryTrail<Entity, _>` into each type that implements it. That allows you get a `QueryTrail<User, _>` to do eager loading with.
davidpdrsn
force-pushed
the
allow-converting-between-query-trail-types
branch
from
ceaa301 to
1e90905
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of fixing
davidpdrsn/juniper-eager-loading#15.
In order to perform eager loading on a
Vec<User>you need to knowwhich associations are being queried. The
QueryTrail<User, _>type hasthat information.
However, this doesn't work for interfaces since if you have an interface
called for example
Entityyou will not get aQueryTrail<User, _>butinstead a
QueryTrail<Entity, _>. That doesn't work to eager loadusers, which means you cannot eager at all. This is because
Entityisan enum with a variant for each type that implements that interface.
With this change we also generate implementations of
IntoforQueryTrail<Entity, _>into each type that implements it. That allowsyou get a
QueryTrail<User, _>to do eager loading with.TODO: