Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Arabic Translation #83

Merged
merged 10 commits into from
Jan 24, 2025
Merged

Add Arabic Translation #83

merged 10 commits into from
Jan 24, 2025

Conversation

smed79
Copy link
Contributor

@smed79 smed79 commented Jan 18, 2025

Add Arabic Translation


Issue on app side:

Days of the week are in English (Sun, Mon, Tue, Wed, Thu, Fri, Sat)



Days in Arabic starting by Sunday are written as following:

الأحد
الاثنين
الثلاثاء
الأربعاء
الخميس
الجمعة
السبت

@davidtakac
Copy link
Owner

The leftover values in English were due to the fact that ar was missing from locales_config.xml. This is now fixed

app/src/main/res/values-ar/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values-ar/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values-ar/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values-ar/strings.xml Show resolved Hide resolved
app/src/main/res/values-ar/strings.xml Show resolved Hide resolved
app/src/main/res/values-ar/strings.xml Show resolved Hide resolved
@davidtakac
Copy link
Owner

I've also fixed the bug where integers such as 24 were showing up in the Latin alphabet. Now they are properly localized too.

@davidtakac davidtakac self-requested a review January 24, 2025 16:12
Copy link
Owner

@davidtakac davidtakac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only remaining bug is line graphs not switching to RTL for Arabic. This is a much bigger effort and I'll have to address it separately. Integrating Vico Charts looks promising so far.

@davidtakac davidtakac merged commit d2b516b into davidtakac:dev Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants