fix(example): Linting errors (react-boilerplate#978)

* fix(example): Linting errors fixes react-boilerplate#975 * enforece arrow-parens
davidwilde · Sep 12, 2016 · 6b2e987 · 6b2e987
1 parent d38ab17
commit 6b2e987
Show file tree

Hide file tree

Showing 12 changed files with 29 additions and 22 deletions.
diff --git a/app/components/A/index.js b/app/components/A/index.js
@@ -6,14 +6,17 @@ import React, { PropTypes } from 'react';
 
 import styles from './styles.css';
 
-function A(props) {
+function A({ ...props }) {
+  const { className, children, href, target, ...rest } = props;
   return (
     <a
-      className={
-        props.className || styles.link
-      }
-      {...props}
-    />
+      href={href}
+      target={target}
+      className={className || styles.link}
+      {...rest}
+    >
+      { children }
+    </a>
   );
 }
 

diff --git a/app/containers/LanguageProvider/selectors.js b/app/containers/LanguageProvider/selectors.js
@@ -3,7 +3,7 @@ import { createSelector } from 'reselect';
 /**
  * Direct selector to the languageToggle state domain
  */
-const selectLanguage = () => state => state.get('language');
+const selectLanguage = () => (state) => state.get('language');
 
 /**
  * Select the language locale

diff --git a/app/store.js b/app/store.js
@@ -9,7 +9,7 @@ import createSagaMiddleware from 'redux-saga';
 import createReducer from './reducers';
 
 const sagaMiddleware = createSagaMiddleware();
-const devtools = window.devToolsExtension || (() => noop => noop);
+const devtools = window.devToolsExtension || (() => (noop) => noop);
 
 export default function configureStore(initialState = {}, history) {
   // Create the store with two middlewares

diff --git a/internals/generators/component/index.js b/internals/generators/component/index.js
@@ -17,7 +17,7 @@ module.exports = {
     name: 'name',
     message: 'What should it be called?',
     default: 'Button',
-    validate: value => {
+    validate: (value) => {
       if ((/.+/).test(value)) {
         return componentExists(value) ? 'A component or container with this name already exists' : true;
       }
@@ -35,7 +35,7 @@ module.exports = {
     default: true,
     message: 'Do you want i18n messages (i.e. will this component use text)?',
   }],
-  actions: data => {
+  actions: (data) => {
     // Generate index.js and index.test.js
     const actions = [{
       type: 'add',

diff --git a/internals/generators/container/index.js b/internals/generators/container/index.js
@@ -11,7 +11,7 @@ module.exports = {
     name: 'name',
     message: 'What should it be called?',
     default: 'Form',
-    validate: value => {
+    validate: (value) => {
       if ((/.+/).test(value)) {
         return componentExists(value) ? 'A component or container with this name already exists' : true;
       }
@@ -44,7 +44,7 @@ module.exports = {
     default: true,
     message: 'Do you want i18n messages (i.e. will this component use text)?',
   }],
-  actions: data => {
+  actions: (data) => {
     // Generate index.js and index.test.js
     const actions = [{
       type: 'add',

diff --git a/internals/generators/language/index.js b/internals/generators/language/index.js
@@ -10,7 +10,7 @@ module.exports = {
     name: 'language',
     message: 'What is the language you want to add i18n support for (e.g. "fr", "de")?',
     default: 'fr',
-    validate: value => {
+    validate: (value) => {
       if ((/.+/).test(value) && value.length === 2) {
         return true;
       }

diff --git a/internals/generators/route/index.js b/internals/generators/route/index.js
@@ -33,7 +33,7 @@ module.exports = {
     type: 'input',
     name: 'component',
     message: 'Which component should the route show?',
-    validate: value => {
+    validate: (value) => {
       if ((/.+/).test(value)) {
         return componentExists(value) ? true : `"${value}" doesn't exist.`;
       }
@@ -45,7 +45,7 @@ module.exports = {
     name: 'path',
     message: 'Enter the path of the route.',
     default: '/about',
-    validate: value => {
+    validate: (value) => {
       if ((/.+/).test(value)) {
         return true;
       }
@@ -56,7 +56,7 @@ module.exports = {
 
   // Add the route to the routes.js file above the error route
   // TODO smarter route adding
-  actions: data => {
+  actions: (data) => {
     const actions = [];
     if (reducerExists(data.component)) {
       data.useSagas = sagasExists(data.component); // eslint-disable-line no-param-reassign

diff --git a/internals/templates/languageProvider/selectors.js b/internals/templates/languageProvider/selectors.js
@@ -3,7 +3,7 @@ import { createSelector } from 'reselect';
 /**
  * Direct selector to the languageToggle state domain
  */
-const selectLanguage = () => state => state.get('language');
+const selectLanguage = () => (state) => state.get('language');
 
 /**
  * Select the language locale

diff --git a/internals/templates/store.js b/internals/templates/store.js
@@ -9,7 +9,7 @@ import createSagaMiddleware from 'redux-saga';
 import createReducer from './reducers';
 
 const sagaMiddleware = createSagaMiddleware();
-const devtools = window.devToolsExtension || (() => noop => noop);
+const devtools = window.devToolsExtension || (() => (noop) => noop);
 
 export default function configureStore(initialState = {}, history) {
   // Create the store with two middlewares

diff --git a/internals/webpack/webpack.dev.babel.js b/internals/webpack/webpack.dev.babel.js
@@ -150,7 +150,7 @@ function templateContent() {
   const body = doc.find('body');
   const dllNames = !dllPlugin.dlls ? ['reactBoilerplateDeps'] : Object.keys(dllPlugin.dlls);
 
-  dllNames.forEach(dllName => body.append(`<script data-dll='true' src='/${dllName}.dll.js'></script>`));
+  dllNames.forEach((dllName) => body.append(`<script data-dll='true' src='/${dllName}.dll.js'></script>`));
 
   return doc.toString();
 }
diff --git a/package.json b/package.json
@@ -103,6 +103,7 @@
       }
     },
     "rules": {
+      "arrow-parens": ["error", "always"],
       "arrow-body-style": [
         2,
         "as-needed"
@@ -136,6 +137,9 @@
       "no-console": 1,
       "no-use-before-define": 0,
       "prefer-template": 2,
+      "class-methods-use-this": 0,
+      "react/forbid-prop-types": 0,
+      "react/jsx-first-prop-new-line": [2, "multiline"],
       "react/jsx-filename-extension": 0,
       "react/jsx-no-target-blank": 0,
       "react/require-extension": 0,
@@ -243,10 +247,10 @@
     "css-loader": "0.25.0",
     "enzyme": "2.4.1",
     "eslint": "3.5.0",
-    "eslint-config-airbnb": "10.0.1",
+    "eslint-config-airbnb": "11.1.0",
     "eslint-import-resolver-webpack": "0.5.1",
     "eslint-plugin-import": "1.14.0",
-    "eslint-plugin-jsx-a11y": "2.2.1",
+    "eslint-plugin-jsx-a11y": "2.2.2",
     "eslint-plugin-react": "6.2.0",
     "eventsource-polyfill": "0.9.6",
     "expect": "1.20.2",

diff --git a/server/logger.js b/server/logger.js
@@ -11,7 +11,7 @@ const divider = chalk.gray('\n-----------------------------------');
 const logger = {
 
   // Called whenever there's an error on the server we want to print
-  error: err => {
+  error: (err) => {
     console.error(chalk.red(err));
   },