Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the project go-getable #6

Open
jzelinskie opened this issue Mar 14, 2018 · 1 comment
Open

make the project go-getable #6

jzelinskie opened this issue Mar 14, 2018 · 1 comment

Comments

@jzelinskie
Copy link

Maybe this is a configuration I have for git, but if I try to go get this repository, I get the following error:

< TONS OF SUBMODULE REGISTRATION AND CLONING >
...
fatal: could not read Username for 'https://github.com': terminal prompts disabled
fatal: clone of 'https://github.com/httpspec/sublime-highlighting' into submodule path '/Users/jzelinskie/OSS/go/faq/src/github.com/generaltso/linguist/data/linguist/vendor/grammars/Sublime-HTTP' failed
Failed to clone 'vendor/grammars/Sublime-HTTP' a second time, aborting
Failed to recurse into submodule path 'data/linguist'
package github.com/generaltso/linguist: exit status 1

If I run the following, everything works flawlessly

go get github.com/jteeuwen/go-bindata/go-bindata
mkdir -p $GOPATH/src/github.com/generaltso/linguist
git clone --depth=1 https://github.com/generaltso/linguist $GOPATH/src/github.com/generaltso/linguist
go get -d github.com/generaltso/linguist
cd $GOPATH/src/github.com/generaltso/linguist
make

This is a shame because I'd like to include linguist in a project that I want to be go-getable and I cannot do so unless I vendor linguist and run its makefile (and carry that knowledge going forward for whenever I want to update linguist as a dependency).

@ianlewis
Copy link

I think the current reason it's not included as @dayvonjersen mentioned to me is that the generated data would need to be checked in and currently generates about 3.5mb of Go code for the language classifier.

I personally think it's reasonable to check it in as 3.5mb isn't really that big, relatively speaking, and the benefits of the module being go gettable far outweigh the downsides.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants