Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(textarea): we need to set the value length state initially as well #2692

Merged
merged 3 commits into from
Jul 31, 2024
Merged

fix(textarea): we need to set the value length state initially as well #2692

merged 3 commits into from
Jul 31, 2024

Conversation

mfranzke
Copy link
Member

Resolves #2691

@mfranzke mfranzke added bug Something isn't working community feedback labels Jul 30, 2024
@mfranzke mfranzke added this to the Release 1.0 milestone Jul 30, 2024
@mfranzke mfranzke self-assigned this Jul 30, 2024
@mfranzke mfranzke linked an issue Jul 30, 2024 that may be closed by this pull request
Textarea: Incorrect count initially on initial value #2691
Closed
@mfranzke mfranzke removed their assignment Jul 30, 2024
@mfranzke mfranzke changed the title fix: we need to set this state initially as well fix(textarea): we need to set the value length state initially as well Jul 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/elements/review/2691-textarea-incorrect-count-initially-on-initial-value

@mfranzke mfranzke enabled auto-merge (squash) July 30, 2024 17:58
@nmerget nmerget self-assigned this Jul 31, 2024
@mfranzke mfranzke merged commit 7a0e87f into main Jul 31, 2024
39 checks passed
@mfranzke mfranzke deleted the 2691-textarea-incorrect-count-initially-on-initial-value branch July 31, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmerget nmerget nmerget approved these changes

@dkolba dkolba Awaiting requested review from dkolba dkolba is a code owner

@annsch annsch Awaiting requested review from annsch annsch is a code owner

Assignees

@nmerget nmerget

Labels
bug Something isn't working community feedback stencil
Projects
None yet
Milestone
Release 1.0
Development

Successfully merging this pull request may close these issues.

Textarea: Incorrect count initially on initial value
2 participants
@mfranzke @nmerget