Remove disableCatdocWordWrap #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having this as an option makes no sense. We should always pass the -w flag to catdoc to prevent it inserting line breaks every 72 characters. With -w passed catdoc will emit a line break whenever it encounters one in the document (e.g. at the end of a paragraph.) Control over wether the line breaks are included in the final output is then determined by the preserveLineBreaks option
tommygnr
pushed a commit
to tommygnr/textract
that referenced
this pull request
Aug 11, 2015
The changes made in dbashford#39 clobber any option passed at the command line. In light of dbashford#54 this code is unnecessary anyway.
|
Good point, and thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having this as an option makes no sense. We should always pass the -w
flag to catdoc to prevent it inserting line breaks every 72 characters.
With -w passed catdoc will emit a line break whenever it encounters one
in the document (e.g. at the end of a paragraph.)
Control over whether the line breaks are included in the final output is
then determined by the preserveLineBreaks option
See #39