Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build badge in README.md [skip ci] #186

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Update build badge in README.md [skip ci] #186

merged 1 commit into from
Sep 26, 2024

Conversation

joeljuca
Copy link
Contributor

Description

The build badge in README.md was updated.

Checklist

  • I've added this contribution to the CHANGELOG.md file.

@joeljuca
Copy link
Contributor Author

Hello there!

First of all, thank you for litecli :) So, this PR is just a friendly tweak to update the build badge in README.md. I noticed the project is using GitHub Actions to do CI but the badge was still pointing to Travis CI. I had this same issue with projects I migrated from Travis to GHA, so I wanted to do the same here.

Having a green badge right in the README.md looks good and tells a story of proper organization. :)

@amjith
Copy link
Member

amjith commented Sep 26, 2024

Thank you for the contribution. Just out of curiosity do you find that badge useful?

It was all the rage back in 2010ish. I'm wondering if they serve a purpose anymore.

@amjith amjith merged commit e58bbcd into dbcli:main Sep 26, 2024
@joeljuca joeljuca deleted the docs/update-build-badge branch September 26, 2024 21:44
@joeljuca
Copy link
Contributor Author

@amjith I do, actually! They're an easy way to check if master/main builds correctly. It's literally a badge right – smt you'd use for some sort of proud. But I think it creates a notion of responsibility, smt like "no commit should break the build, otherwise the badge will be red and it will not look good on the project's home page."

Also, when I see a project using a Travis CI the very first idea that comes to mind is "the project hasn't been touched since the deprecation of Travis CI – which has been quite a long time ago." – which is not the case for litecli (and other db CLIs, it seems).

But I was definitely there when it all started in 2010 – so perhaps I'm just an old man keeping up with old practices. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants