Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix los brett #317

Merged
merged 27 commits into from
Aug 7, 2021
Merged

Fix los brett #317

merged 27 commits into from
Aug 7, 2021

Conversation

jlmaurer
Copy link
Collaborator

@jlmaurer jlmaurer commented Aug 6, 2021 •
edited
Loading

This replaces #316 (see also #312)
Fixes the line-of-sight calculation when using statevectors and miscellaneous bugs

Description

  • fixes some bugs in the I/O routines and unit test suite
  • adds unit tests
  • Fixes the LOS calculation and simplifies the code logic

Motivation and Context

Fixes #79
Fixes #122
Fixes #273
Replaces #316

How Has This Been Tested?

  • All tests pass locally
  • ran autopep8 on the whole repo

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have added an explanation of what your changes do and why you'd like us to include them.
  • I have written new tests for your core changes, as applicable.
  • I have successfully ran tests with your changes locally.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

jlmaurer and others added 25 commits July 15, 2021 09:06
@jlmaurer
add in ecef2enu
9eea55d
@jlmaurer
start some new unit tests for test_util
f6e93ce
@bbuzz31 @jlmaurer
comment out extra LOS calcs (From LOS file)
e7c9b6c
@jlmaurer
Add in ecef2enu
a35464b
@jlmaurer
convert ECEF unit vectors to ENU
696c7a7
@jlmaurer
Fix LOS calculation and remove print statements
5c06dd5
@jlmaurer
add a slant range threshold for sanity checking los
175097f
@jlmaurer
Ensure that the geo2rdr object is deleted
78d05d8
@jlmaurer
update unit tests and fix a bug
b7b4b4e
@jlmaurer
Bunch of clean up and making everything consistent
84c0ad3
@jlmaurer
fix a couple bugs
81ae34e
@jlmaurer
Add unit tests and docstrings
ac31bdc
@jlmaurer
refactor losreader to be cleaner, add unit tests
8549bc3
@jlmaurer
clarify a couple points in losreader
8ea053e
@jlmaurer
start refactoring LOS calc
eb6cd95
@jlmaurer
move some files around
a8f17e4
@bbuzz31
BB_few_fixes
f251d02 
change name of variable (los_file -> lookvector)
fix masking with a reshape
make shape of outputs consistent (LOS file, orbit file)
@jlmaurer
Ensure that input shape is preserved in losreader
53b618b
@bbuzz31
fix and write
59c8487
@bbuzz31
remove extra write
5e44a35
@bbuzz31
test fixes from Jeremy
65e7fd6
@jlmaurer
Fix call to getLookVectors
9a039b1
@jlmaurer
Fix some bugs and make sure los vars get carried through correctly
86af6dc
@jlmaurer
Fix unit tests for GMAO and a few bugs
0b8730f
@jlmaurer
autopep8 fixes
8c5f3be
@jlmaurer jlmaurer requested review from bbuzz31 and dbekaert August 6, 2021 20:38
@jlmaurer jlmaurer marked this pull request as ready for review August 6, 2021 20:38
@jlmaurer jlmaurer mentioned this pull request Aug 6, 2021
Closed
@jlmaurer
Copy link
Collaborator Author

jlmaurer commented Aug 6, 2021

@bbuzz31 and @dbekaert All unit tests passing! Can be reviewed and merged.

@jlmaurer jlmaurer merged commit 6ec4744 into dbekaert:dev Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbekaert dbekaert dbekaert approved these changes

@bbuzz31 bbuzz31 Awaiting requested review from bbuzz31

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
NISAR project release
3 participants
@jlmaurer @dbekaert @bbuzz31