Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise better error for missing subdatasets #348

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

garlic-os
Copy link
Contributor

Description

Changes the WeatherModel bbox accessor to raise a specific error when the weather model given does not contain any subdatasets.

Motivation and Context

The code has been crashing here sometimes with a list index out of bounds error while trying to open the first subdataset in the given file. For better debugging, this change makes this case raise a different error that better explains what has happened.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • X ] I have added an explanation of what your changes do and why you'd like us to include them.
  • I have written new tests for your core changes, as applicable.
  • I have successfully ran tests with your changes locally.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@jlmaurer jlmaurer merged commit 296b8b8 into dbekaert:dev Jun 22, 2022
@garlic-os garlic-os deleted the missing-subdatasets-better-error branch June 12, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants