Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing geometry extensions + adding ISCE3 to dependencies #361

Merged
merged 4 commits into from
Oct 4, 2022
Merged

Removing geometry extensions + adding ISCE3 to dependencies #361

merged 4 commits into from
Oct 4, 2022

Conversation

piyushrpt
Copy link
Collaborator

@piyushrpt piyushrpt commented Oct 3, 2022 •
edited
Loading

Description

  • Remove geometry extensions and prep for using isce3 as geometry engine
  • Pull in changes in Fix los calc #332
  • Update unit tests to match changes in 332

Motivation and Context

  • Prep for using ISCE3 as geometry engine for LOS ray tracing
  • Created new env called RISCE3 which might replace current RAiDER env if things look good in future

How Has This Been Tested?

  • py.test test/ has same number of failures in scenario tests as before
  • Output of raiderDelay.py --date 20200103 --time 23:00:00 -b 39 40 -79 -78 --model MERRA2 --zref 15000 --out matches before and after changes. ERA5 is down for maintenance so could not use that

@piyushrpt piyushrpt requested a review from jlmaurer October 3, 2022 23:34
jlmaurer
jlmaurer requested changes Oct 4, 2022
View reviewed changes
Copy link
Collaborator

@jlmaurer jlmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good start! You may want to remove your UN/PW from the merra2 api call.

jlmaurer
jlmaurer approved these changes Oct 4, 2022
View reviewed changes
Copy link
Collaborator

@jlmaurer jlmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlmaurer jlmaurer mentioned this pull request Oct 4, 2022
Closed
8 tasks
@piyushrpt piyushrpt merged commit 10dd8b4 into dev Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlmaurer jlmaurer jlmaurer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piyushrpt @jlmaurer