-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace gdal +osr with rasterio + pyproj #365
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmarshak
reviewed
Oct 21, 2022
cmarshak
reviewed
Oct 21, 2022
cmarshak
reviewed
Oct 21, 2022
cmarshak
reviewed
Oct 21, 2022
cmarshak
reviewed
Oct 21, 2022
cmarshak
reviewed
Oct 21, 2022
jlmaurer
reviewed
Oct 21, 2022
@@ -100,51 +98,47 @@ def ecef2enu(xyz, lat, lon, height): | |||
return np.stack((e, n, u), axis=-1) | |||
|
|||
|
|||
def gdal_extents(fname): | |||
def rio_extents(fname): | |||
if os.path.exists(fname + '.vrt'): | |||
fname = fname + '.vrt' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may not be needed anymore. We were facing an issue where gdal wouldn't read certain attributes from the .dat file but would from the .vrt file. I think it was mainly the NoDataValue. I don't think rasterio has this limitation; @cmarshak do you happen to know?
jlmaurer
approved these changes
Oct 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per discussion
gdal
withrasterio
osr
withpyproj
Raytracing
are flushed outMotivation and Context
How Has This Been Tested?
prepFromAria.py
might need more testing.