-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker #371
Docker #371
Conversation
ENTRYPOINT ["/usr/bin/bash"] | ||
CMD ["-l"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This right now just gives you a bash shell in the container. I suspect we'll update it to RAiDER.__main__
if/when that's available.
Note: This action needs to be available in the default branch ( |
Co-authored-by: dbekaert <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This sets up the mechanics for building a docker container for any PR (to ensure it builds) and and push to main or dev, and then push it to this repositories container registry. See: https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry
container images will always be tagged with the current version number, and then:
test
latest
Note: I'm using actions I've developed and maintained here:
https://github.com/ASFHyP3/actions
Specifically:
reusable-git-object-name.yml
reusable-docker-ghcr.yml
The version number generated for the docker container will be the same as reported by:
which for the current state of this PR, would look like:
which breaks down to
<latest-version-tag>-<commits-since-tag>-g<commit-short-hash>
. This will tie any particular docker image directly to the associated commit used to build it, and the "package version" (notably, RAiDER reports a static version based on theversion.txt
file, which can be out of sync with the git tags; I'll tackle that in a subsequent PR).If you're on a version tag (or the commit associated with the version tag) the version will be reported just as:
as expected.
Type of change
Checklist: