Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in docker build #384

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Fix typo in docker build #384

merged 1 commit into from
Nov 9, 2022

Conversation

jhkennedy
Copy link
Collaborator

@jhkennedy jhkennedy commented Nov 9, 2022

Workflow didn't run because the needs: value was wrong.

@jhkennedy jhkennedy added the bug Something isn't working label Nov 9, 2022
@jhkennedy
Copy link
Collaborator Author

We can see the docker build is working! And in the packages registry:
image

which brings you to:
image

@dbekaert, you'll have to make the container images public. You should be able to follow this link to do it (Scroll to the bottom):
https://github.com/dbekaert/packages/container/raider/settings

Of once you're viewing the packages, click the package setting in the bottom right.

@dbekaert
Copy link
Owner

dbekaert commented Nov 9, 2022

@jhkennedy i changed the settings. Can you confirm we are good to go?

Copy link
Owner

@dbekaert dbekaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing, should be public visible now too

@jhkennedy jhkennedy merged commit 88e60bd into dev Nov 9, 2022
@jhkennedy
Copy link
Collaborator Author

@jhkennedy i changed the settings. Can you confirm we are good to go?

@dbekaert Confirmed!

@jhkennedy jhkennedy deleted the jhkennedy-patch-1 branch November 10, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants