-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for HRRR #386
Support for HRRR #386
Conversation
@piyushrpt How are we currently validating ray-tracing. Comparing zenith projection to slant with slant directly? or providing zenith unit vector compared with zenith delay option? |
We are comparing zenith projected to slant - and checking magnitudes. The only way of really doing this is to build a synthetic weather model with constant values where the computed delay should turn out proportional to ray length. This will be a unit test that will be important and should be developed going forward. The zenith case does not test any aspects of spatial interpolation - so has limited value. |
Here is the example input file that I'm testing with right now:
Things look ok - we have reconciled reading HRRR with ERA5. But I seem to be encountering a whole bunch of nans here: RAiDER/tools/RAiDER/models/weatherModel.py Line 558 in 1585569
All interpolate calls in that function receive valid data but return only NaNs. If there are assumptions being made about arrays being contiguous etc this makes sense. Extra set of eyes familiar with code here would help. |
Numerically, this should work. Things to check include
Hydrostatic delay seems high but I suspect its because of units - possibly acceleration in geopotential height. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments, looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll go ahead and approve since they are pretty minor comments
Description
Motivation and Context
How Has This Been Tested?