Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #11 #12

Merged
merged 3 commits into from
Oct 9, 2021
Merged

fixes #11 #12

merged 3 commits into from
Oct 9, 2021

Conversation

trangntt-016
Copy link
Contributor

No description provided.

@trangntt-016 trangntt-016 marked this pull request as ready for review October 8, 2021 20:38
@trangntt-016
Copy link
Contributor Author

Hi @dbelokon , here are the features I've just added to your code, pls check it.
[x] The -c or --config flags accept a file path to a JSON config file.
[x] If the file is missing, or can't be parsed as JSON, exit with an appropriate error message.
[x] If the -c or --config option is provided, ignore all other options (i.e., a config file overrides other options on the command line).
[x] The program should ignore any options in the config file it doesn't recognize. For example, if the SSG doesn't support stylesheets, ignore a stylesheet property.
[x] If the config file is missing any options, assume the usual defaults. For example, use dist/ as the output directory if it isn't specified.

@trangntt-016 trangntt-016 changed the title fix issue-11 fix #11 issue-11 Oct 8, 2021
@trangntt-016 trangntt-016 changed the title fix #11 issue-11 fix#11 issue-11 Oct 8, 2021
@trangntt-016 trangntt-016 changed the title fix#11 issue-11 fixes #11 issue-11 Oct 8, 2021
@trangntt-016 trangntt-016 changed the title fixes #11 issue-11 fixes #11 Oct 8, 2021
Copy link
Owner

@dbelokon dbelokon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow!! Looks nice! thank you for your contribution! @trangntt-016

@dbelokon dbelokon merged commit 72f154d into dbelokon:master Oct 9, 2021
@trangntt-016
Copy link
Contributor Author

My pleasure @dbelokon 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants