arbitrary objects #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ular objects to be parsed)
Closed
th3n3wguy
reviewed
Apr 3, 2018
| JSON.stringify(next) | ||
| } | ||
|
|
||
| return next; |
There was a problem hiding this comment.
Won't this actually cause a schema change for the output of the information logged to the server? If I remember correctly, the message that is created from this parser is always a string, which might cause problems for anyone trying to use it.
There was a problem hiding this comment.
This doesn't change the message (which is correct that it is always a string). The additional is an any[], so I think we'll be fine there. I think we want to keep the type of the logged additional, but still verify it is valid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow arbitrary objects to be logged to console (this will allow circular objects to be parsed), but not to HTTP Service